atoomula commented on a change in pull request #1214: SAMZA-2375, SAMZA-2376:
Add display name to UdfMetadata and handle trailing semi-colons
URL: https://github.com/apache/samza/pull/1214#discussion_r344433734
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/interfaces/UdfMetadata.java
##########
@@ -32,6 +32,7 @@
public class UdfMetadata {
private final String name;
Review comment:
Added a description of what this field means. Well, it is just udf name. For
UdfMetadata, it should not matter whether it is logicalName or a physicalName,
it is just the name that the udf will be referred as. I feel name is
appropriate. What do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
