Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r348762740
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
##########
@@ -415,20 +407,34 @@ public void stop() {
/**
- * Checks if a request has expired.
+ * Checks if a request has expired. If this request is due to a control
action, then expiry timeout can be overridden
+ * otherwise defaults to
+ *
* @param request the request to check
* @return true if request has expired
*/
private boolean isRequestExpired(SamzaResourceRequest request) {
long currTime = Instant.now().toEpochMilli();
- boolean requestExpired = currTime -
request.getRequestTimestamp().toEpochMilli() > requestExpiryTimeout;
+ boolean requestExpired = currTime -
request.getRequestTimestamp().toEpochMilli() > getRequestTimeout(request);
if (requestExpired) {
LOG.info("Request for Processor ID: {} on host: {} with creation time:
{} has expired at current time: {} after timeout: {} ms.",
request.getProcessorId(), request.getPreferredHost(),
request.getRequestTimestamp(), currTime, requestExpiryTimeout);
Review comment:
good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
