Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r348870081
##########
File path:
samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManager.java
##########
@@ -102,7 +102,10 @@ public void launchStreamProcessor(SamzaResource resource,
CommandBuilder builder
@Override
public void stopStreamProcessor(SamzaResource resource) {
- // no op
+ SamzaResourceStatus status = new
SamzaResourceStatus(resource.getContainerId(), "diagnostics",
SamzaResourceStatus.PREEMPTED);
Review comment:
Yes, this is needed for my test to propagate stop callback, I don't think so
there is a test for testing stopStreamProcessor today :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
