Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r352916102
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
##########
@@ -174,13 +175,7 @@ public void run() {
* When host-affinity is enabled, all allocated resources are buffered by
the hostName as key
*
* If the requested host is not available, the thread checks to see if the
request has expired. If it has expired
- * then two cases are handled separately
- *
- * Case 1: host-affinity is enabled, looks for allocated resouces on
ANY_HOST and issues a container start if available,
- * otherwise issues an ANY_HOST request
- * Case 2: host-affinity is disabled, expired requests are not handled,
allocator waits for cluster manager to issue
- * resources
- * TODO: SAMZA-2330 Hadle expired request for host affinity disabled
case
+ * please refer to {@code containerManager#handleContainerLaunch} for
constraints to handle expired requests
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
