Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r352913736
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
##########
@@ -110,7 +110,8 @@
*/
protected final ResourceRequestState resourceRequestState;
/**
- * Tracks the expiration of a request for resources.
+ * Tracks the configured expiration of a resource request defaults to {@code
ClusterManagerConfig#CLUSTER_MANAGER_REQUEST_TIMEOUT_MS}
+ * is specified or {@code
ClusterManagerConfig#DEFAULT_CONTAINER_REQUEST_TIMEOUT_MS} otherwise
*/
Review comment:
Changed the name to configuredRequestExpiryTimeout since this is just
timeout by config, do not need to add^ details here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
