mynameborat commented on a change in pull request #1228: SAMZA-2412 : Adding
SamzaContainer metric that is 0 when container-starting, 1 when started.
URL: https://github.com/apache/samza/pull/1228#discussion_r353360310
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -764,6 +764,7 @@ class SamzaContainer(
containerListener.afterStart()
}
metrics.containerStartupTime.set((System.nanoTime() - startTime)/1000000)
+ metrics.containerStarted.set(1)
Review comment:
Not related to this PR, but curious what will be the behavior of the auto
sizing controller if this metric is broken. Wondering if it can differentiate
between metrics broken vs container not started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
