mynameborat commented on a change in pull request #1228: SAMZA-2412 : Adding 
SamzaContainer metric that is 0 when container-starting, 1 when started.
URL: https://github.com/apache/samza/pull/1228#discussion_r353358853
 
 

 ##########
 File path: 
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
 ##########
 @@ -764,6 +764,7 @@ class SamzaContainer(
         containerListener.afterStart()
       }
       metrics.containerStartupTime.set((System.nanoTime() - startTime)/1000000)
 
 Review comment:
   Can we use (`container-startup-time`) metric instead to infer if the 
container has started?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to