dnishimura commented on a change in pull request #1227: SAMZA-2404: Container
Placement Handler for dispatching container placement messages between
metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r353915547
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -242,6 +259,8 @@ public void stop() {
// Shutdown allocator thread
containerAllocator.stop();
+ // Shutdown container placement handler thread
+ containerPlacementHandler.stop();
Review comment:
Would you need the similar thread join pattern for the container placement
handler thread , similar to the container allocator thread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
