dnishimura commented on a change in pull request #1227: SAMZA-2404: Container
Placement Handler for dispatching container placement messages between
metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r353916134
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -562,6 +582,17 @@ void
onResourceCompletedWithUnknownStatus(SamzaResourceStatus resourceStatus, St
}
}
+ /**
+ * Registers a ContainerPlacement action, this method is invoked by
ContainerPlacementHandler. {@link ContainerProcessManager}
+ * needs to intercept container placement actions between
ContainerPlacementHandler and {@link ContainerManager} to avoid
+ * cyclic dependency between {@link ContainerManager} and {@link
ContainerAllocator} on each other
+ *
+ * @param requestMessage request containing details of the desited container
placement action
+ */
+ public void
registerContainerPlacementAction(ContainerPlacementRequestMessage
requestMessage) {
+ // Call the ContainerManager#registerContainerPlacementAction
Review comment:
Is this a `TODO:` for a follow on PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
