cameronlee314 commented on a change in pull request #1237: SAMZA-2406: Add
ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader
as well as PropertiesConfigLoaderFactory implementations.
URL: https://github.com/apache/samza/pull/1237#discussion_r362941730
##########
File path: samza-api/src/main/java/org/apache/samza/config/MapConfig.java
##########
@@ -41,6 +42,17 @@ public MapConfig(Map<String, String> map) {
this(Collections.singletonList(map));
}
+ /**
+ * Build a {@link MapConfig} from {@link Properties}
+ *
+ * @param properties to build MapConfig
+ */
+ public MapConfig(Properties properties) {
Review comment:
In order to keep this API class simpler, can you please not add another
constructor to this class? You could convert the `Properties` to a `Map` first
and then use the existing constructor for this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
