cameronlee314 commented on a change in pull request #1237: SAMZA-2406: Add ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader as well as PropertiesConfigLoaderFactory implementations. URL: https://github.com/apache/samza/pull/1237#discussion_r362943972
########## File path: samza-core/src/test/java/org/apache/samza/config/loaders/TestPropertiesConfigLoader.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.config.loaders; + +import java.util.Collections; +import org.apache.samza.SamzaException; +import org.apache.samza.config.Config; +import org.apache.samza.config.ConfigLoader; +import org.apache.samza.config.MapConfig; +import org.junit.Test; + +import static org.junit.Assert.*; + + +public class TestPropertiesConfigLoader { + @Test + public void testCanReadPropertiesConfigFiles() { + ConfigLoader loader = new PropertiesConfigLoaderFactory().getLoader( + new MapConfig(Collections.singletonMap("path", getClass().getResource("/test.properties").getPath()))); + + Config config = loader.getConfig(); + assertEquals("bar", config.get("foo")); + } + + @Test + public void testCanNotReadWithoutPath() { + try { + ConfigLoader loader = new PropertiesConfigLoaderFactory().getLoader(new MapConfig()); + loader.getConfig(); + fail("should have gotten a samza exception"); + } catch (SamzaException e) { Review comment: Since you don't need to check anything in the exception, you can use `@Test(expected = SamzaException.class)` and then you don't need the try-catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
