cameronlee314 commented on a change in pull request #1237: SAMZA-2406: Add ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader as well as PropertiesConfigLoaderFactory implementations. URL: https://github.com/apache/samza/pull/1237#discussion_r363899576
########## File path: samza-api/src/main/java/org/apache/samza/config/ConfigLoaderFactory.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.config; + +/** + * The factory for an {@link ConfigLoader} instance to loader job config. + */ +public interface ConfigLoaderFactory { + /** + * Get an instance of {@link ConfigLoader} + * + * @param config start up config which specifies properties needed for the loader to load config. Review comment: In these javadocs in which we have a start-up config and a full job config, can you please make sure to keep the qualifier whenever you use the term config? It will help ensure users don't get confused by the terminology. For example, "start up config which specifies properties needed for the loader to load **full job** config". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
