rmatharu commented on a change in pull request #1227: SAMZA-2404: [SEP-22]
Container Placement Handler for dispatching container placement messages
between metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r366499861
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -150,6 +152,13 @@
*/
private final Optional<StreamRegexMonitor> inputStreamRegexMonitor;
+ /**
+ * Container placement action dispatcher and util
+ */
+ private final ContainerPlacementUtil containerPlacementUtil;
Review comment:
Either rename this to ContainerPlacementMetastoreReader or make all its
methods static so that it is really a Util.
A Util should not be instantiated like this and have a complete lifecycle,
With this change there two lifecycled objects and a thread hanging in this
class, can the two be merged into a single clean object that encapsulates the
other and the thread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
