lakshmi-manasa-g commented on a change in pull request #1259: SAMZA-2444: 
JobModel save in CoordinatorStreamStore resulting flush for each message
URL: https://github.com/apache/samza/pull/1259#discussion_r371364488
 
 

 ##########
 File path: 
samza-api/src/main/java/org/apache/samza/metadatastore/MetadataStore.java
 ##########
 @@ -67,6 +68,16 @@ default void putAll(Map<String, byte[]> entries) {
    */
   void delete(String key);
 
+  /**
+   * Deletes the mapping with the specified set.
 
 Review comment:
   Is this operation meant to be atomic? Does an impl of MetadataStore ensure 
that either all or none of this map is deleted?
   Is this operation meant to be idempotent? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to