alnzng commented on issue #1259: SAMZA-2444: JobModel save in 
CoordinatorStreamStore resulting flush for each message
URL: https://github.com/apache/samza/pull/1259#issuecomment-578887026
 
 
   > Now I looked at the coodinator stream impl for metadatstore, it seems we 
shouldn't couple flush with put/putall/delete/deleteall. It should be done as a 
separate call at the end of updates. The current impl is hideous and can cause 
further perf problems down the road.
   
   @xinyuiscool Do you mean we should remove `flush` calls from 
`put/putall/delete/deleteall`? And let the callers of those functions decide 
when to do `flush` operation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to