bkonold opened a new pull request #1261: SAMZA-2447: Checkpoint dir removal 
should only search in valid store dirs
URL: https://github.com/apache/samza/pull/1261
 
 
   **Symptom:** NPE when attempting to remove old checkpoint directories.
    
   **Cause:** Removal of old checkpoints assumes every file in the logged store 
base directory is also a directory, which may not be true if the user has 
configured it to a path that is not exclusive to store contents.
    
   **Changes:** Check that the result of `listFiles` is non-null before 
attempting to delete.
    
   **Tests:** Wrote a test to mimic the behavior of a non-directory file in the 
logged store base directory. Test fails without the patch, passes with it.
   
   **API Changes:** None
    
   **Upgrade Instructions:** None
    
   **Usage Instructions:** None

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to