prateekm commented on a change in pull request #1261: SAMZA-2447: Checkpoint
dir removal should only search in valid store dirs
URL: https://github.com/apache/samza/pull/1261#discussion_r372111920
##########
File path:
samza-core/src/test/scala/org/apache/samza/storage/TestTransactionalStateTaskStorageManager.java
##########
@@ -492,6 +493,32 @@ public void
testWriteChangelogOffsetFilesWithNoChangelogOffset() throws IOExcept
fail("Should have thrown an exception if no changelog offset found for
checkpointed store");
}
+ @Test
+ public void testRemoveOldCheckpoints() {
Review comment:
Looks like this is testing the specific sub-case when listFiles returns
null. If so, let's rename method to reflect that (e.g.
testRemoveOldCheckpointsWhenXYZ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
