abhishekshivanna commented on issue #1290: SAMZA-2468: Make Standby containers respond to shutdown request URL: https://github.com/apache/samza/pull/1290#issuecomment-590997151 LGTM nit: can we call the latch `standbyShutdownLatch` instead of `stopSignalLatch`. Reasons: - Since its only used in the case if the container is a standby container - The fact that it is invoked from a signal handler is an implementation detail. container.shutdown() can be called from anywhere.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
