Sanil15 commented on a change in pull request #1290: SAMZA-2468: Make Standby
containers respond to shutdown request
URL: https://github.com/apache/samza/pull/1290#discussion_r384179277
##########
File path:
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
##########
@@ -126,6 +126,45 @@ class TestSamzaContainer extends AssertionsForJUnit with
MockitoSugar {
verify(this.runLoop).run()
}
+
+ @Test
+ def testShutDownSequenceForStandbyContainers() {
+ class ShutDownSignal(container: SamzaContainer) extends Runnable {
+ def run(): Unit = {
+ Thread.sleep(2000)
Review comment:
runLoop.run is blocking call so cannot do this without sleep
> Also, we should verify that the countdown() was actually called
well the verification is done on the shutdown methods which only gets called
once that latch is counted down if the latch was not all these shutdown methods
won't be invoked, hence I do not feel exposing this latch outside and verifying
on it is necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
