Sanil15 commented on a change in pull request #1296: SAMZA-2475: Add a
allocated resource expiry timeout in samza yarn type of apps
URL: https://github.com/apache/samza/pull/1296#discussion_r386727439
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterResourceManager.java
##########
@@ -132,6 +132,9 @@ public ClusterResourceManager(Callback callback) {
public abstract void stop(SamzaApplicationState.SamzaAppStatus status);
+ public boolean isResourceExpired(SamzaResource resource) {
Review comment:
Kubernetes does not have a concept of expired allocated resource so this
method needs a default implementation, it cannot belong to SamzaResource
because that is yarn agnostic class and timeout is read from Yarn config and
not a samza config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
