prateekm commented on a change in pull request #1296: SAMZA-2475: Add a
allocated resource expiry timeout in samza yarn type of apps
URL: https://github.com/apache/samza/pull/1296#discussion_r387185817
##########
File path:
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java
##########
@@ -575,6 +576,17 @@ public void onStopContainerError(ContainerId containerId,
Throwable t) {
}
}
+ @Override
+ public boolean isResourceExpired(SamzaResource resource) {
+ /**
Review comment:
Use `//` for comments inside methods, not `/*`. IntelliJ warns about
dangling javadocs for these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
