xinyuiscool commented on a change in pull request #1309: SAMZA-2453: Update
ClusterBasedJobCoordinator to support Beam jobs
URL: https://github.com/apache/samza/pull/1309#discussion_r390451149
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -551,8 +553,23 @@ private static void
runClusterBasedJobCoordinator(String[] args) {
throw new SamzaException(e);
}
- ClusterBasedJobCoordinator jc = createFromConfigLoader(submissionConfig);
- jc.run();
+ ApplicationConfig appConfig = new ApplicationConfig(submissionConfig);
+
+ if (appConfig.getAppMainClass().isPresent()) {
Review comment:
Please add some comments about the use cases here for Beam. what's the
expected main/args being passed in and what are we going to do with them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
