kw2542 commented on a change in pull request #1309: SAMZA-2453: Update
ClusterBasedJobCoordinator to support Beam jobs
URL: https://github.com/apache/samza/pull/1309#discussion_r390463665
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -634,4 +651,20 @@ static ClusterBasedJobCoordinator
createFromConfigLoader(Config submissionConfig
metadataStore,
config);
}
+
+ @VisibleForTesting
+ static String[] toArgs(ApplicationConfig config) {
+ List<String> args = new ArrayList<>(config.size() * 2);
+
+ config.forEach((key, value) -> {
+ if (key.equals(ApplicationConfig.APP_MAIN_ARGS)) {
+ args.addAll(Arrays.asList(value.split("\\s")));
+ } else {
Review comment:
Yes,
if block is to pass native Beam pipeline options such as
--runner SamzaRunner --maxSourceParallelism=1024
else block is to change other native samza configs with --config key=value,
such as
--config job.name=beam-test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
