Sanil15 commented on a change in pull request #1335: Optimizing startpoint
manager to not make successive bootstrapMessage calls to coordinator-store
URL: https://github.com/apache/samza/pull/1335#discussion_r401848479
##########
File path:
samza-core/src/main/java/org/apache/samza/startpoint/StartpointManager.java
##########
@@ -158,8 +158,25 @@ public void writeStartpoint(SystemStreamPartition ssp,
TaskName taskName, Startp
* @return {@link Optional} of {@link Startpoint} for the {@link
SystemStreamPartition}.
* It is empty if it does not exist or if it is too stale.
*/
+ @VisibleForTesting
public Optional<Startpoint> readStartpoint(SystemStreamPartition ssp) {
- return readStartpoint(ssp, null);
Review comment:
Revert the change on line line 162 calling `readStartpoint(ssp, null);` will
still do the intended, do not need line 163-165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
