Sanil15 commented on a change in pull request #1335: Optimizing startpoint
manager to not make successive bootstrapMessage calls to coordinator-store
URL: https://github.com/apache/samza/pull/1335#discussion_r401851188
##########
File path:
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
##########
@@ -127,6 +127,7 @@
*/
private static final String AM_JMX_ENABLED = "yarn.am.jmx.enabled";
private static final String CLUSTER_MANAGER_JMX_ENABLED =
"cluster-manager.jobcoordinator.jmx.enabled";
+ private static final String CLUSTER_MANAGER_STARTPOINT_FANOUT_ENABLED =
"job.startpoint.fanout.enabled";
Review comment:
If this config is called `job.startpoint.fanout.enabled`, isn't it better to
be a part of JobConfig than ClusterManagerConfig?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
