mynameborat commented on a change in pull request #1327: SAMZA-2493: Keep checkpoint manager consumer open for repeated polling URL: https://github.com/apache/samza/pull/1327#discussion_r403304166
########## File path: samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ########## @@ -76,6 +76,8 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec, val producerRef: AtomicReference[SystemProducer] = new AtomicReference[SystemProducer](getSystemProducer()) val producerCreationLock: Object = new Object + val stopConsumerAfterFirstRead: Boolean = new TaskConfig(config).getCheckpointManagerConsumerStopAfterFirstRead Review comment: can we put in a comment on when this config is set vs not? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
