bkonold commented on a change in pull request #1327: SAMZA-2493: Keep checkpoint manager consumer open for repeated polling URL: https://github.com/apache/samza/pull/1327#discussion_r403364372
########## File path: samza-core/src/main/java/org/apache/samza/config/TaskConfig.java ########## @@ -105,6 +105,7 @@ private static final String BROADCAST_STREAM_PATTERN = "^[\\d]+$"; private static final String BROADCAST_STREAM_RANGE_PATTERN = "^\\[[\\d]+\\-[\\d]+\\]$"; public static final String CHECKPOINT_MANAGER_FACTORY = "task.checkpoint.factory"; + public static final String INTERNAL_CHECKPOINT_MANAGER_CONSUMER_STOP_AFTER_FIRST_READ = "samza.internal.task.checkpoint.consumer.stop.after.first.read"; Review comment: I initially thought of something like `samza.internal.task.checkpoint.consumer.keep.open` but thought that the name in the PR currently is more expressive of behavior. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
