cameronlee314 commented on a change in pull request #1344: SAMZA-2510:
Incorrect shutdown status due to race between runloop and process callback
thread
URL: https://github.com/apache/samza/pull/1344#discussion_r408449754
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -185,6 +180,11 @@ public void run() {
containerMetrics.utilization().set(((double) activeNs) / totalNs);
}
}
+
+ if (throwable != null) {
Review comment:
Is the following scenario possible?
1) Async processing has a bad message in flight
2) Manual call to `RunLoop.shutdown`
3) Exit main while loop
4) `throwable` is still null since async processing is incomplete
5) Async processing throws exception
6) Container will exit with "success"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
