mynameborat commented on a change in pull request #1344: SAMZA-2510: Incorrect
shutdown status due to race between runloop and process callback thread
URL: https://github.com/apache/samza/pull/1344#discussion_r409002839
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -185,6 +180,11 @@ public void run() {
containerMetrics.utilization().set(((double) activeNs) / totalNs);
}
}
+
+ if (throwable != null) {
Review comment:
Added a java doc, updated the PR description and also added some details to
the JIRA ticket to outline what is this PR targeting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
