prateekm commented on a change in pull request #1434:
URL: https://github.com/apache/samza/pull/1434#discussion_r503564053
##########
File path: samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java
##########
@@ -44,7 +44,11 @@
private static final String CONFIG_SCHEDULING_JITTER_PERCENT =
"scheduling.jitter.percent";
- private static final int DEFAULT_SCHEDULING_JITTER_PERCENT = 0;
+ // Default scheduling jitter set to 100 to ensure every monitor is scheduled
with an initial jitter.
+ // The change SAMZA-2595 creates a new scheduler/thread for every monitor.
Jitter ensures that there is a delay in
+ // scheduling of every monitor to ensure all the monitors do not start at
the same time, to avoid spike on host
+ // and to not overwhelm the metric reporting service.
+ private static final int DEFAULT_SCHEDULING_JITTER_PERCENT = 100;
Review comment:
Thanks for the description. Let's also mention this change under "API
changes" section of the PR description, so that it's easy to document at
release time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
