prateekm commented on a change in pull request #1434:
URL: https://github.com/apache/samza/pull/1434#discussion_r503576722
##########
File path:
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java
##########
@@ -100,4 +110,19 @@ public void run() {
}
};
}
+
+ /**
+ * Creates a ScheduledThreadPoolExecutor with core pool size 1
+ * @return ScheduledExecutorService
+ */
+ private ScheduledExecutorService createScheduler() {
Review comment:
We've already run into performance limits of what single threaded
execution for all monitors can do with some monitors within LinkedIn, so while
the current implementation avoided premature optimization, it's not
sustainable. A better way to achieve the exclusivity goal will be to write the
monitors with such side-effects in a "thread-safe" way. @shanthoosh are you
aware of any existing monitors could be impacted by this change? If so, we can
update them.
Shekhar, let's also call this out as another potentially backwards
incompatible change in the "API changes" section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
