kw2542 commented on a change in pull request #1437:
URL: https://github.com/apache/samza/pull/1437#discussion_r527258814
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java
##########
@@ -111,6 +111,10 @@ public void init() {
systemConsumer.start();
systemProducer.register(SOURCE);
systemProducer.start();
+ Runtime.getRuntime().addShutdownHook(new Thread(() -> {
Review comment:
+1, shutdown hooks are being executed when JVM exists, it does not seem
to fit this scenario. It could be less appropriate compared to finalize() as
the warning messages we get from Kafka is emitted in finalize() as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
