prateekm commented on a change in pull request #1437:
URL: https://github.com/apache/samza/pull/1437#discussion_r527265232
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java
##########
@@ -111,6 +111,10 @@ public void init() {
systemConsumer.start();
systemProducer.register(SOURCE);
systemProducer.start();
+ Runtime.getRuntime().addShutdownHook(new Thread(() -> {
Review comment:
@kw2542 We shouldn't use finalize either. The Kafka warning shows that
we're leaking client references somewhere without closing them. We should try
to find and fix the underlying object lifecycle issue first instead of fixing
the symptom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
