mynameborat commented on a change in pull request #1448:
URL: https://github.com/apache/samza/pull/1448#discussion_r537618206
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetExecutionContainerIdMapping.java
##########
@@ -0,0 +1,65 @@
+/*
Review comment:
Either needs a merge from latest master or this is an extra file that
needs to be removed since it got renamed in master and the merge is keeping
this as is.
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -236,11 +236,20 @@ public void start() {
diagnosticsManager.get().start();
}
+ if (jobConfig.getApplicationMasterHighAvailabilityEnabled()) {
+ LOG.info(
+ "Set neededProcessors prior to starting clusterResourceManager
because it gets running containres from prev attempts in AM HA.");
+
state.processorCount.set(state.jobModelManager.jobModel().getContainers().size());
+
state.neededProcessors.set(state.jobModelManager.jobModel().getContainers().size());
+ }
+
LOG.info("Starting the cluster resource manager");
clusterResourceManager.start();
-
state.processorCount.set(state.jobModelManager.jobModel().getContainers().size());
-
state.neededProcessors.set(state.jobModelManager.jobModel().getContainers().size());
+ if (!jobConfig.getApplicationMasterHighAvailabilityEnabled()) {
+
state.processorCount.set(state.jobModelManager.jobModel().getContainers().size());
+
state.neededProcessors.set(state.jobModelManager.jobModel().getContainers().size());
+ }
Review comment:
Did you miss this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
