mynameborat commented on a change in pull request #1448:
URL: https://github.com/apache/samza/pull/1448#discussion_r537826816
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -254,10 +257,10 @@ public void start() {
});
if (jobConfig.getApplicationMasterHighAvailabilityEnabled()) {
// don't request resource for container that is already running
- state.runningProcessors.keySet().forEach(containerId -> {
- processorToHost.remove(containerId);
- state.neededProcessors.decrementAndGet();
- });
+ LOG.info("have in samza app state: " + state.runningProcessors.size() +
" running processors");
+ LOG.info("have in processorToHost " + processorToHost.size());
+ state.runningProcessors.keySet().forEach(processorToHost::remove);
+ LOG.info("after removing running processors : have in processorToHost "
+ processorToHost.size());
Review comment:
can we consolidate the log statements? guess it is used for testing
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -420,6 +423,7 @@ public void onStreamProcessorLaunchSuccess(SamzaResource
resource) {
state.pendingProcessors.remove(processorId);
state.runningProcessors.put(processorId, resource);
if (state.neededProcessors.decrementAndGet() == 0) {
+ LOG.info("Manasa#: setting job healhty to true");
Review comment:
remove the log :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
