PawasChhokra commented on a change in pull request #1446:
URL: https://github.com/apache/samza/pull/1446#discussion_r539872461
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java
##########
@@ -63,7 +69,11 @@
private final Instant requestTimestamp;
public SamzaResourceRequest(int numCores, int memoryMB, String
preferredHost, String processorId) {
- this(numCores, memoryMB, preferredHost, processorId, Instant.now());
+ this(numCores, memoryMB, preferredHost, processorId, Instant.now(), null);
Review comment:
When we make the actual container request to Yarn, the null value will
ensure that the rack requirement for that request is ignored, similar to how it
currently is without rack awareness. The code on Yarn side checks specifically
for it to be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
