PawasChhokra commented on a change in pull request #1446:
URL: https://github.com/apache/samza/pull/1446#discussion_r539888750
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java
##########
@@ -109,15 +135,24 @@ public String toString() {
", requestId='" + requestId + '\'' +
", processorId=" + processorId +
", requestTimestampMs=" + requestTimestamp +
+ ", faultDomains=" + convertFaultDomainSetToString() +
'}';
}
- /**
- * Requests are ordered by the processor type and the time at which they
were created.
- * Requests with timestamps in the future for retries take less precedence
than timestamps in the past or current.
- * Otherwise, active processors take precedence over standby processors,
regardless of timestamp.
- * @param o the other
- */
+ private String convertFaultDomainSetToString() {
+ StringBuilder faultDomainSb = new StringBuilder();
Review comment:
Yes it should. I had added the FaultDomain toString method later on
hence forgot to remove this. Thanks for observing :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
