PawasChhokra commented on a change in pull request #1446:
URL: https://github.com/apache/samza/pull/1446#discussion_r546189549
##########
File path:
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnFaultDomainManager.java
##########
@@ -117,4 +120,8 @@ public boolean hasSameFaultDomains(String host1, String
host2) {
}
return hostToRackMap;
}
+
+ private void initMetrics() {
+ hostToFaultDomainCacheUpdates = metricsRegistry.newCounter(groupName,
"host-to-fault-domain-cache-updates");
+ }
Review comment:
I extracted it just in case we add other metrics in the future. Having
said that, I don't see any other metrics being needed as of now, so have
inlined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
