PawasChhokra commented on a change in pull request #1446:
URL: https://github.com/apache/samza/pull/1446#discussion_r547120067
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java
##########
@@ -233,9 +275,13 @@ private void initiateStandbyAwareAllocation(String
activeContainerID, String res
standbyHost, activeContainerID, standbyHost, resourceID);
FailoverMetadata failoverMetadata =
this.registerActiveContainerFailure(activeContainerID, resourceID);
+ Set<FaultDomain> allowedFaultDomains = new HashSet<>();
+ if (isFaultDomainAwareStandbyEnabled()) {
+ allowedFaultDomains =
getAllowedFaultDomainsForStandbyContainerGivenContainerId(activeContainerID);
+ }
// record the resource request, before issuing it to avoid race with
allocation-thread
SamzaResourceRequest resourceRequestForActive =
- containerAllocator.getResourceRequest(activeContainerID,
standbyHost);
+ containerAllocator.getResourceRequest(activeContainerID,
standbyHost, allowedFaultDomains);
Review comment:
I've simplified this now as explained in the next comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
