mynameborat commented on a change in pull request #1468:
URL: https://github.com/apache/samza/pull/1468#discussion_r587921386
##########
File path:
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigurationGenerator.java
##########
@@ -351,10 +351,10 @@ private void configureSerdes(Map<String, String> configs,
Map<String, StreamEdge
private void addSerdes(KV<Serde, Serde> serdes, String streamId, Map<String,
Serde> keySerdeMap,
Map<String, Serde> msgSerdeMap) {
if (serdes != null) {
- if (serdes.getKey() != null && !(serdes.getKey() instanceof NoOpSerde)) {
+ if (serdes.getKey() != null) {
keySerdeMap.put(streamId, serdes.getKey());
}
- if (serdes.getValue() != null && !(serdes.getValue() instanceof
NoOpSerde)) {
+ if (serdes.getValue() != null) {
Review comment:
what class description are you referring to?
Like I pointed out earlier, the harm is creating `copies of serialized
serdes & corresponding configurations`. I couldn't find much of historical
context here.
@prateekm or @nickpan47 do you guys know why we specifically added this
check for `instanceof NoOpSerde` and exclude them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
