Sanil15 commented on a change in pull request #1468:
URL: https://github.com/apache/samza/pull/1468#discussion_r587949755
##########
File path:
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigurationGenerator.java
##########
@@ -351,10 +351,10 @@ private void configureSerdes(Map<String, String> configs,
Map<String, StreamEdge
private void addSerdes(KV<Serde, Serde> serdes, String streamId, Map<String,
Serde> keySerdeMap,
Map<String, Serde> msgSerdeMap) {
if (serdes != null) {
- if (serdes.getKey() != null && !(serdes.getKey() instanceof NoOpSerde)) {
+ if (serdes.getKey() != null) {
keySerdeMap.put(streamId, serdes.getKey());
}
- if (serdes.getValue() != null && !(serdes.getValue() instanceof
NoOpSerde)) {
+ if (serdes.getValue() != null) {
Review comment:
@bharathkk sorry i meant java docs on line 265
```
* We try to preserve the number of Serde instances before and after
serialization. However we don't
* guarantee that references shared between these serdes instances (e.g.
an Jackson ObjectMapper shared
* between two json serdes) are shared after deserialization too.
*
* Ideally all the user defined objects in the application should be
serialized and de-serialized in one pass
* from the same output/input stream so that we can maintain reference
sharing relationships.
*
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
