mynameborat commented on pull request #1476: URL: https://github.com/apache/samza/pull/1476#issuecomment-803025761
> > How are we computing the utilization? Using `job.container.thread.pool.size` may tie into the implementation detail of the using `FixedThreadPool` which can potentially change. It will be good idea to also track the current `poolSize` of the thread pool and doing so will decouple from the concrete thread pool used underneath. > > @mynameborat Good point. I think this is partially because the existing `containerThreadPoolSize` metric is coupled with the configured value, but it actually makes more sense to report the actual pool size rather than the config, as the configured value can be obtained directly by reading the config instead of reading the metrics. Thus I changed the existing `containerThreadPoolSize` to report the current thread pool size. Let me know if that looks good to you. Thanks for adding it 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
