mynameborat commented on a change in pull request #1476:
URL: https://github.com/apache/samza/pull/1476#discussion_r597923669
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
##########
@@ -49,6 +49,7 @@ class SamzaContainerMetrics(
val physicalMemoryMb = newGauge("physical-memory-mb", 0.0F)
val physicalMemoryUtilization = newGauge("physical-memory-utilization", 0.0F)
val containerThreadPoolSize = newGauge("container-thread-pool-size", 0L)
Review comment:
Given you are updating as part of `hostStatisticsMonitor`, you will
need to remove the code in `SamzaContainer` which updates this metric on
startup to `job.container.thread.pool.size`. This would prevent any weird
metric drop given the `poolSize` only gets to this upper bound eventually and
when there are not enough new tasks submitted, it may not end up creating
additional threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
