This is an automated email from the ASF dual-hosted git repository.
atoomula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git
The following commit(s) were added to refs/heads/master by this push:
new ea14805 SAMZA-2639: Samza-sql: Fix ANY type validation for the parsed
args (#1479)
ea14805 is described below
commit ea14805a0588ac3cd7ffbef0e23463962bf9246b
Author: Aditya Toomula <[email protected]>
AuthorDate: Tue Mar 23 15:27:20 2021 -0700
SAMZA-2639: Samza-sql: Fix ANY type validation for the parsed args (#1479)
---
samza-sql/src/main/java/org/apache/samza/sql/planner/Checker.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/samza-sql/src/main/java/org/apache/samza/sql/planner/Checker.java
b/samza-sql/src/main/java/org/apache/samza/sql/planner/Checker.java
index 4a3c657..28ba187 100644
--- a/samza-sql/src/main/java/org/apache/samza/sql/planner/Checker.java
+++ b/samza-sql/src/main/java/org/apache/samza/sql/planner/Checker.java
@@ -98,7 +98,9 @@ class Checker implements SqlOperandTypeChecker {
if (parsedSqlArgType.getSqlTypeName() == SqlTypeName.CHAR &&
udfArgumentAsSqlType == SqlTypeName.VARCHAR) {
return true;
} else if (!Objects.equals(parsedSqlArgType.getSqlTypeName(),
udfArgumentAsSqlType)
- && !ANY_SQL_TYPE_NAMES.contains(udfArgumentAsSqlType) &&
hasOneUdfMethod(udfMetadata)) {
+ && !ANY_SQL_TYPE_NAMES.contains(udfArgumentAsSqlType)
+ &&
!ANY_SQL_TYPE_NAMES.contains(parsedSqlArgType.getSqlTypeName())
+ && hasOneUdfMethod(udfMetadata)) {
// 3(b). Throw up and fail on mismatch between the SamzaSqlType and
CalciteType for any argument.
String msg = String.format("Type mismatch in udf class: %s at
argument index: %d." +
"Expected type: %s, actual type: %s.",
udfMetadata.getName(),
