prateekm commented on a change in pull request #1489:
URL: https://github.com/apache/samza/pull/1489#discussion_r616966296
##########
File path: samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointId.java
##########
@@ -36,7 +36,7 @@
private final long millis;
private final long nanos;
- public CheckpointId(long millis, long nanos) {
+ private CheckpointId(long millis, long nanos) {
this.millis = millis;
this.nanos = nanos;
}
Review comment:
For context, the nanos suffix was added as a workaround to distinguish
b/w two store checkpoints that may have been created within the same
milliseconds (e.g. when using manual commit with task coordinator).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]