dxichen commented on a change in pull request #1489:
URL: https://github.com/apache/samza/pull/1489#discussion_r616981383
##########
File path: samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointId.java
##########
@@ -61,6 +61,11 @@ public long getNanos() {
return nanos;
}
+ /**
+ * WARNING: Do not change the toString() representation. It is used for
serde'ing {@link CheckpointId} as part of task
+ * checkpoints, in conjunction with {@link #fromString(String)}.
+ * @return the String representation of this {@link CheckpointId}.
+ */
Review comment:
We would have to accept both versions in the fromString/deserialize
method to perserve backwards compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
