cameronlee314 opened a new pull request #1541: URL: https://github.com/apache/samza/pull/1541
Issues: `TestKafkaCheckpointManager.scala` uses a real Kafka server for unit tests. This dependency significantly increases the time it takes to run the unit tests. Changes: 1. Move all testing from `TestKafkaCheckpointManager.scala` into `TestKafkaCheckpointManagerJava.java` and use mocking instead of a real Kafka server. 2. Created `KafkaCheckpointManagerIntegrationTest.java` in `samza-test` so that we still have an integration test for `KafkaCheckpointManager` which uses real Kafka. 3. Add `consumer.unsubscribe()` to `IntegrationTestHarness` which reduces shutdown time of Kafka server for any tests which depend on `IntegrationTestHarness`. Tests: `./gradlew build` API changes: N/A This change reduces the time it takes to run `samza-kafka` unit tests by almost 2 minutes, so running the build without integration tests also gets reduced by about 2 minutes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
