cameronlee314 commented on a change in pull request #1541: URL: https://github.com/apache/samza/pull/1541#discussion_r723765031
########## File path: samza-test/src/test/java/org/apache/samza/test/kafka/KafkaCheckpointManagerIntegrationTest.java ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.test.kafka; + +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicInteger; +import com.google.common.collect.ImmutableMap; +import org.apache.samza.application.TaskApplication; +import org.apache.samza.application.descriptors.TaskApplicationDescriptor; +import org.apache.samza.config.JobConfig; +import org.apache.samza.config.JobCoordinatorConfig; +import org.apache.samza.config.KafkaConfig; +import org.apache.samza.config.TaskConfig; +import org.apache.samza.serializers.StringSerde; +import org.apache.samza.system.IncomingMessageEnvelope; +import org.apache.samza.system.kafka.descriptors.KafkaInputDescriptor; +import org.apache.samza.system.kafka.descriptors.KafkaSystemDescriptor; +import org.apache.samza.task.MessageCollector; +import org.apache.samza.task.StreamTask; +import org.apache.samza.task.StreamTaskFactory; +import org.apache.samza.task.TaskCoordinator; +import org.apache.samza.test.framework.StreamApplicationIntegrationTestHarness; +import org.junit.Before; +import org.junit.Test; + +import static org.junit.Assert.assertEquals; + + +/** + * 1) Run app and consume messages + * 2) Commit only for first message + * 3) Shutdown application + * 4) Run app a second time to use the checkpoint + * 5) Verify that we had to re-process the message after the first message + */ +public class KafkaCheckpointManagerIntegrationTest extends StreamApplicationIntegrationTestHarness { + private static final String SYSTEM = "kafka"; + private static final String INPUT_STREAM = "inputStream"; + private static final Map<String, String> CONFIGS = ImmutableMap.of( + JobCoordinatorConfig.JOB_COORDINATOR_FACTORY, "org.apache.samza.standalone.PassthroughJobCoordinatorFactory", + JobConfig.PROCESSOR_ID, "0", + TaskConfig.CHECKPOINT_MANAGER_FACTORY, "org.apache.samza.checkpoint.kafka.KafkaCheckpointManagerFactory", + KafkaConfig.CHECKPOINT_REPLICATION_FACTOR(), "1", + TaskConfig.COMMIT_MS, "-1"); // manual commit only Review comment: Integration tests are more expensive, so do you think that we will gain something out of testing v2 reads in an integration test which covers more than what we already have in the unit tests? I'm not sure how much extra is covered by having an integration test for reading v2 checkpoints. We shouldn't need an integration test for all flows, but if you think it would still be helpful to have one for reading v2 checkpoints, then I can add one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
