mynameborat opened a new pull request #1583: URL: https://github.com/apache/samza/pull/1583
**Problem**: ContainerLaunchUtil during its launch sequence swallows exception and proceeds to shutdown with 0 status code. This causes AM to not restart the container. **Description**: With the run method, as part of launch sequence we have various initialization steps before kicking off the container. In case of exceptions during this step, the run method catches all erros but only logs them and proceeds to shutdown as usual. Due to normal exit, AM treats the container completed successfully and hence doesn't restart causing the failed container to remain failed. **Changes**: - Exit with status code 1 in case of exception during launch - Fix the error log to include both actual failure and container exception **Tests**: - Added unit test to validate if the system is exiting with the right status code upon encountering exception **API Changes**: None **Usage Instructions**: None **Upgrade Instructions**: None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
