mynameborat commented on a change in pull request #1583:
URL: https://github.com/apache/samza/pull/1583#discussion_r806221403



##########
File path: 
samza-core/src/main/java/org/apache/samza/runtime/ContainerLaunchUtil.java
##########
@@ -179,15 +181,26 @@ private static void run(
 
       if (containerRunnerException != null) {
         log.error("Container stopped with Exception. Exiting process now.", 
containerRunnerException);
-        System.exit(1);
+        exitProcess(1);
       }
     } catch (Throwable e) {
-      log.error("Container stopped with Exception. ", 
containerRunnerException);
+      log.error("Exiting the process due to {}. \nContainer runner exception: 
{}", e, containerRunnerException);

Review comment:
       Fixed the log statements. Here is the sample output
   
   ```
   12:38:29.055 [main] ERROR org.apache.samza.runtime.ContainerLaunchUtil - 
Exiting the process due to
   java.lang.IllegalArgumentException: ApplicationDescriptorImpl has to be 
either TaskApplicationDescriptorImpl or StreamApplicationDescriptorImpl. class 
org.apache.samza.application.descriptors.ApplicationDescriptorImpl$$EnhancerByMockitoWithCGLIB$$1d97dd82
 is not supported
        at 
org.apache.samza.task.TaskFactoryUtil.getTaskFactory(TaskFactoryUtil.java:54) 
~[samza-core_2.11/:?]
        at 
org.apache.samza.runtime.ContainerLaunchUtil.run(ContainerLaunchUtil.java:127) 
[samza-core_2.11/:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_172]
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_172]
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_172]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_172]
        at 
org.powermock.api.mockito.internal.invocation.MockitoMethodInvocationControl$MockedRealMethod.invoke(MockitoMethodInvocationControl.java:343)
 [powermock-api-mockito-1.6.6.jar:?]
        at 
org.mockito.internal.invocation.realmethod.CleanTraceRealMethod.invoke(CleanTraceRealMethod.java:30)
 [mockito-core-1.10.19.jar:?]
        at 
org.mockito.internal.invocation.InvocationImpl.callRealMethod(InvocationImpl.java:112)
 [mockito-core-1.10.19.jar:?]
        at 
org.mockito.internal.stubbing.answers.CallsRealMethods.answer(CallsRealMethods.java:41)
 [mockito-core-1.10.19.jar:?]
        at 
org.mockito.internal.stubbing.StubbedInvocationMatcher.answer(StubbedInvocationMatcher.java:34)
 [mockito-core-1.10.19.jar:?]
        at 
org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:91) 
[mockito-core-1.10.19.jar:?]
        at 
org.powermock.api.mockito.internal.invocation.MockitoMethodInvocationControl.performIntercept(MockitoMethodInvocationControl.java:247)
 [powermock-api-mockito-1.6.6.jar:?]
        at 
org.powermock.api.mockito.internal.invocation.MockitoMethodInvocationControl.invoke(MockitoMethodInvocationControl.java:199)
 [powermock-api-mockito-1.6.6.jar:?]
        at org.powermock.core.MockGateway.doMethodCall(MockGateway.java:173) 
[powermock-core-1.6.6.jar:?]
        at org.powermock.core.MockGateway.doMethodCall(MockGateway.java:155) 
[powermock-core-1.6.6.jar:?]
        at org.powermock.core.MockGateway.methodCall(MockGateway.java:132) 
[powermock-core-1.6.6.jar:?]
        at 
org.apache.samza.runtime.ContainerLaunchUtil.run(ContainerLaunchUtil.java) 
[samza-core_2.11/:?]
        at 
org.apache.samza.runtime.TestContainerLaunchUtil.testRunWithException(TestContainerLaunchUtil.java:64)
 [samza-core_2.11/:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_172]
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_172]
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_172]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_172]
        at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68) 
[junit-4.12.jar:4.12]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:316)
 [powermock-module-junit4-1.6.6.jar:?]
        at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89) 
[junit-4.12.jar:4.12]
        at 
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
 [junit-4.12.jar:4.12]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:300)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:131)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.access$100(PowerMockJUnit47RunnerDelegateImpl.java:59)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner$TestExecutorStatement.evaluate(PowerMockJUnit47RunnerDelegateImpl.java:147)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.evaluateStatement(PowerMockJUnit47RunnerDelegateImpl.java:107)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:288)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:87) 
[junit-4.12.jar:4.12]
        at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:50) 
[junit-4.12.jar:4.12]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:208)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:147)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:121)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34) 
[junit-4.12.jar:4.12]
        at 
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44) 
[junit-4.12.jar:4.12]
        at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:123)
 [powermock-module-junit4-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:121)
 [powermock-module-junit4-common-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53)
 [powermock-module-junit4-common-1.6.6.jar:?]
        at 
org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59) 
[powermock-module-junit4-1.6.6.jar:?]
        at org.junit.runner.JUnitCore.run(JUnitCore.java:137) 
[junit-4.12.jar:4.12]
        at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
 [junit-rt.jar:?]
        at 
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
 [junit-rt.jar:?]
        at 
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
 [junit-rt.jar:?]
        at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) 
[junit-rt.jar:?]
   12:38:29.071 [main] ERROR org.apache.samza.runtime.ContainerLaunchUtil - 
Container runner exception: 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to